API/DEPR: replace kwarg "pat" with "sep" in str.[r]partition #23767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @h-vetinari! Thanks for submitting the PR.
|
WillAyd
requested changes
Nov 18, 2018
| @@ -2410,8 +2410,11 @@ def rsplit(self, pat=None, n=-1, expand=False): | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| pat : str, default whitespace | |||
| sep : str, default whitespace | |||
There was a problem hiding this comment.
Let's still keep pat documented but with a deprecated directive
WillAyd
added
Deprecate
WillAyd
reviewed
Nov 18, 2018
| String to split on. | ||
| pat : str, default whitespace | ||
| .. deprecated:: 0.24.0 | ||
| Use ``sep`` instead |
There was a problem hiding this comment.
Thanks! Do we need a newline after this or does it render OK?
There was a problem hiding this comment.
I saw this directive recently in https://pandas.pydata.org/pandas-docs/stable/generated/pandas.Series.astype.html, and then took the code from:
Line 4916 in 0409521
IOW, should be fine. :)
WillAyd
approved these changes
Nov 18, 2018
|
Failure is a flaky hypothesis test. |
1 task
|
thanks @h-vetinari |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff